Add an endpoint for closing an experiment #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. UI clients for example can close the experiment when a user closed the graphs. Fixes eclipse-cdt-cloud#96 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
close-experiment
branch
from
c7012d2
to
458f8d6
Compare
bhufmann
added a commit
to bhufmann/tsp-typescript-client
that referenced
this pull request
Nov 2, 2023
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. This change follows the TSP update provided by: eclipse-cdt-cloud/trace-server-protocol#95 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/tsp-typescript-client
that referenced
this pull request
Nov 2, 2023
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. This change follows the TSP update provided by: eclipse-cdt-cloud/trace-server-protocol#95 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/tsp-python-client
that referenced
this pull request
Nov 2, 2023
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. This change follows the TSP update provided by: eclipse-cdt-cloud/trace-server-protocol#95 Also add CLI option and unit test for this. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Nov 2, 2023
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. This change follows the TSP update provided by: eclipse-cdt-cloud/trace-server-protocol#95 Fixes eclipse-cdt-cloud#1024 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/tsp-python-client
that referenced
this pull request
Apr 3, 2024
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore. This change follows the TSP update provided by: eclipse-cdt-cloud/trace-server-protocol#95 Also add CLI option and unit test for this. Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this it's possible to close an experiment on the server. Upon reception of the command the server can dispose allocated resources hence the client doesn't need them anymore.
UI clients, for example, can close the experiment when a user closed the graphs.
Fixes #96
Signed-off-by: Bernd Hufmann [email protected]