Use __str__ instead of to_string() #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with str(object) and print(object). It is the more "pythonic" way. Replace all .format strings with fstrings and remove linter directives. Signed-off-by: Matthew Khouzam <[email protected]>
bhufmann
requested changes
Nov 2, 2023
tsp_cli_client
Outdated
| @@ -428,7 +428,7 @@ if __name__ == "__main__": | |||
| if options.type_id is not None: | |||
| response = tsp_client.fetch_configuration(options.type_id, options.list_configuration) | |||
| if response.status_code == 200: | |||
| print(' {0}'.format(response.model.to_string())) | |||
| print(f' {response.model} | |||
There was a problem hiding this comment.
this leads to an error SyntaxError: unterminated string literal (detected at line 431)
You need to terminate the string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with str(object) and print(object). It is the more "pythonic" way.
Replace all .format strings with fstrings and remove linter directives.