Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an endpoint for closing an experiment #60

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ optional arguments:
--list-experiment UUID
Get details on the given experiment
--list-experiments List all open experiments on the server
--close-experiment UUID
Close an experiment on the server
--delete-experiment UUID
Delete an experiment on the server
--list-outputs UUID Get details on the given trace
Expand Down Expand Up @@ -147,6 +149,7 @@ Examples:
./tsp_cli_client --open-experiment EXP_NAME --paths PATHS
./tsp_cli_client --list-experiments
./tsp_cli_client --list-experiment UUID
./tsp_cli_client --close-experiment UUID
./tsp_cli_client --delete-experiment UUID [--do-delete-traces]
./tsp_cli_client --list-outputs UUID
./tsp_cli_client --get-tree OUTPUT_ID --uuid UUID
Expand Down
6 changes: 6 additions & 0 deletions test_tsp.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,14 @@ def test_open_experiment(self, kernel, other):
os.path.basename(kernel), traces)
assert response.status_code == 200

exp_uuid = response.model.UUID

response = self.tsp_client.fetch_experiments()
assert len(response.model.experiments) == 1

response = self.tsp_client.close_experiment(exp_uuid)
assert response.model.indexin_status == "CLOSED"

self._delete_experiments()
self._delete_traces()

Expand Down
19 changes: 19 additions & 0 deletions tsp/tsp_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,25 @@ def fetch_experiment(self, uuid):
print("get trace failed: {0}".format(response.status_code))
return TspClientResponse(None, response.status_code, response.text)

def close_experiment(self, uuid):
'''
Close a specific experiment
:param uuid: Experiment UUID to fetch
:return: :class:`TspClientResponse <Experiment>` object
:rtype: TspClientResponse
'''
api_url = '{0}experiments/{1}:close'.format(self.base_url, uuid)
parameters = {'parameters': {}}

response = requests.put(api_url, json=parameters, headers=headers)

if response.status_code == 200:
return TspClientResponse(Experiment(json.loads(response.content.decode('utf-8'))),
response.status_code, response.text)
else: # pragma: no cover
print("delete experiment failed: {0}".format(response.status_code))
return TspClientResponse(None, response.status_code, response.text)

def delete_experiment(self, uuid):
'''
Delete a specific experiment
Expand Down
11 changes: 11 additions & 0 deletions tsp_cli_client
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ if __name__ == "__main__":
help="Get details on the given experiment", metavar="UUID")
parser.add_argument("--list-experiments", dest="list_experiments",
action='store_true', help="List all open experiments on the server")
parser.add_argument("--close-experiment", dest="close_experiment",
help="Close an experiment on the server", metavar="UUID")
parser.add_argument("--delete-experiment", dest="delete_experiment",
help="Delete an experiment on the server", metavar="UUID")
parser.add_argument("--list-outputs", dest="list_outputs",
Expand Down Expand Up @@ -323,6 +325,15 @@ if __name__ == "__main__":
else:
sys.exit(1)

if options.close_experiment:
response = tsp_client.close_experiment(options.close_experiment)
if response.status_code == 200:
print("Successfully closed experiment")
sys.exit(0)
else:
print("Failed closing experiment with error " + response.status_code)
sys.exit(1)

if options.delete_experiment:
response = tsp_client.delete_experiment(options.delete_experiment)
if response.status_code == 200:
Expand Down