-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get virtual table #63
Get virtual table #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Small comment on the code.
Please do a git rebase the change on the latest in master. No merge commit.
Also, there should be some minimal unit test added. Please note when running the unit test, it will WIPE-OUT your local Trace Compass server workspace. So, backup your workspace before running any unit tests. The workspace and be found ~/.tracecompass-webapp.
There is warning in the README but often it gets unnoticed:
Line 38 in 5ded7d6
**Note: Executing the tests will delete all traces and experiments from trace server workspace. Backup workspace before running the tests or start from fresh workspace.** |
print(" cells:") | ||
for i, cell in enumerate(self.cells): | ||
cell.print() | ||
print(f" {'-' * 10}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also tags
when the search_filter_expression is set to indicate that there is a match. tags
is bitmask and right now we only support one non-null value if the cell matches. Maybe should print matched
or not matched
in case of searching. tags
is an optional field and might not be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So based on my understanding, if tags==8 , then I should return matched? Or should I just return the tags itself?
Because based on the docs, it seems that 0 is none, 1/2 are reserved, 4 is border and 8 is highlight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous review comments have not been addressed in the latest update.
Also, please
- rebase to the latest in master branch (there have been commits).
- add some unit test
- don't use merge commits
a576e6e
to
6eff8c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the contribution.
Implementation of the get-virtual-table-lines in the tsp-python-client. The endpoint is already present in the tsp-server.
Get Virtual Table Header (i.e., columns)
This implementation gets the table column information from the TSP server.
python3 tsp_cli_client --get-virtual-table-columns OUTPUT_ID --uuid UUID
Get Virtual Table Lines
To fetch the table data from the TSP server, we may use either
--table-line-index
(as the start index row) or--table-times
(as the times of the rows).python3 tsp_cli_client --get-virtual-table-lines OUTPUT_ID --uuid UUID --table-line-index INDEX --table-line-count COUNT --table-column-ids IDs --table-search-direction DIRECTION --table-search-expression COLUMN_ID EXPRESSION
Misc
The info regarding both functionalities has been included in the readme file.