Get virtual table #63
Conversation
There was a problem hiding this comment.
It looks good. Small comment on the code.
Please do a git rebase the change on the latest in master. No merge commit.
Also, there should be some minimal unit test added. Please note when running the unit test, it will WIPE-OUT your local Trace Compass server workspace. So, backup your workspace before running any unit tests. The workspace and be found ~/.tracecompass-webapp.
There is warning in the README but often it gets unnoticed:
Line 38 in 5ded7d6
| print(" cells:") | ||
| for i, cell in enumerate(self.cells): | ||
| cell.print() | ||
| print(f" {'-' * 10}") |
There was a problem hiding this comment.
There is also tags when the search_filter_expression is set to indicate that there is a match. tags is bitmask and right now we only support one non-null value if the cell matches. Maybe should print matched or not matched in case of searching. tags is an optional field and might not be present.
There was a problem hiding this comment.
So based on my understanding, if tags==8 , then I should return matched? Or should I just return the tags itself?
Because based on the docs, it seems that 0 is none, 1/2 are reserved, 4 is border and 8 is highlight.
kavehshahedi
force-pushed
the
get-virtual-table-lines
branch
from
a576e6e
to
6eff8c2
Compare
Implementation of the get-virtual-table-lines in the tsp-python-client. The endpoint is already present in the tsp-server.
Get Virtual Table Header (i.e., columns)
This implementation gets the table column information from the TSP server.
python3 tsp_cli_client --get-virtual-table-columns OUTPUT_ID --uuid UUIDGet Virtual Table Lines
To fetch the table data from the TSP server, we may use either
--table-line-index(as the start index row) or--table-times(as the times of the rows).python3 tsp_cli_client --get-virtual-table-lines OUTPUT_ID --uuid UUID --table-line-index INDEX --table-line-count COUNT --table-column-ids IDs --table-search-direction DIRECTION --table-search-expression COLUMN_ID EXPRESSIONMisc
The info regarding both functionalities has been included in the readme file.