add state and arrow requests #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewKhouzam
requested changes
Jul 4, 2024
arfio
force-pushed
the
state-arrow-requests
branch
from
9e04b58
to
56c0a3e
Compare
This change follows the following TSP specification: https://eclipse-cdt-cloud.github.io/trace-server-protocol/#tag/TimeGraph/operation/getStates https://eclipse-cdt-cloud.github.io/trace-server-protocol/#tag/TimeGraph/operation/getArrows Signed-off-by: Arnaud Fiorini <[email protected]>
arfio
force-pushed
the
state-arrow-requests
branch
from
56c0a3e
to
fcbc0c2
Compare
bhufmann
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks for the contribution. It looks good. I have a small comment (unused variable) though.
@arfio Do you plan to provide a follow-up PR on top of this PR to add a command-line interface for these added tsp_client methods?
| response = requests.post(api_url, json=params, headers=headers) | ||
|
|
||
| if response.status_code == 200: | ||
| response_size = len(bytes(response.text, 'utf-8')) |
There was a problem hiding this comment.
response_size can be removed because not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the implementation for the arrows and states routes.
This change follows the following TSP specification: