Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include jakarta.annotation-api in BOM #1035

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

pzygielo
Copy link
Contributor

No description provided.

@pzygielo pzygielo marked this pull request as ready for review May 20, 2024 07:23
@dmatej dmatej added this to the 3.1.1 milestone May 20, 2024
@dmatej
Copy link
Contributor

dmatej commented May 20, 2024

However Annotation 3.0 is for Jakarta EE 11, right? Then it should go rather to 4.0.0-prepare branch. Or we could merge that branch to master and create 3.x branch from the last commit before.

@pzygielo
Copy link
Contributor Author

However Annotation 3.0 is for Jakarta EE 11, right?

Hmmm... This change in BOM only follows what is set in parent already.

Then it should go rather to 4.0.0-prepare branch. Or we could merge that branch to master and create 3.x branch from the last commit before.

Perhaps preparation could be finalized and merged to master.

create 3.x branch from the last commit before

This will not work then as the said annotation-api is bumped in master already. But some commit before, like edb7a0b could do.

@pzygielo pzygielo merged commit a48d4b4 into eclipse-ee4j:master May 20, 2024
2 checks passed
@pzygielo pzygielo deleted the jb branch May 20, 2024 16:54
@dmatej dmatej modified the milestones: 3.1.1, 4.0.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants