-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused local variables #641
Conversation
9114f4a
to
3ffe8f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comments, in many projects the latest copyright is put on top as the first line. Thought I don't think we have any conventions for this.
I think chronological order is better in this section, so I follow already established examples glassfish-hk2/class-model/osgi.bundle Lines 1 to 4 in 3286871
glassfish-hk2/class-model/src/main/java/org/glassfish/hk2/classmodel/reflect/ParsingContext.java Lines 1 to 4 in 3286871
Lines 3 to 6 in 3286871
|
This discussion repeats - I had the same thoughts as you, @pzygielo , but the issue was that the copyright plugin takes the first line. Also I found that in many projects is the newer year first, probably for the same reason, so finally I had to agree with Arjan. And another issue - using comma between years is enumerating years in which something new was added. I would prefer rather the minus character, range. Then it would be perfect :-D (but currently I don't know how copyright plugin works with that - last changes I did just added the line with 2022) |
This should be resolved in the plugin.
https://www.eclipse.org/projects/handbook/#ip-copyright-headers:
|
Hmm, I see this rule as quite problematic and unusual. But it probably doesn't change anything (meaning in relation to law). |
It probably should, too, but at the same time it's still good to have a somewhat standard way of doing this. Anyway, it was a just a remark. Don't let it hold up the merge. Just something to think about. |
No description provided.