Remove unused local variables

[pzygielo]

No description provided.

[arjantijms]

Just one comments, in many projects the latest copyright is put on top as the first line. Thought I don't think we have any conventions for this.

[pzygielo]

Just one comments, in many projects the latest copyright is put on top as the first line. Thought I don't think we have any conventions for this.

I think chronological order is better in this section, so I follow already established examples

glassfish-hk2/class-model/osgi.bundle

Lines 1 to 4 in 3286871

	#
	# Copyright (c) 2010, 2018 Oracle and/or its affiliates. All rights reserved.
	# Copyright (c) 2021 Payara Services Ltd.
	#

glassfish-hk2/class-model/src/main/java/org/glassfish/hk2/classmodel/reflect/ParsingContext.java

Lines 1 to 4 in 3286871

	/*
	* Copyright (c) 2010, 2018 Oracle and/or its affiliates. All rights reserved.
	* Copyright (c) 2019 Payara Foundation and/or its affiliates. All rights reserved.
	*

glassfish-hk2/hk2-api/pom.xml

Lines 3 to 6 in 3286871

	Copyright (c) 2010, 2018 Oracle and/or its affiliates. All rights reserved.
	Copyright (c) 2019, 2020 Payara Services Ltd.

[dmatej]

This discussion repeats - I had the same thoughts as you, @pzygielo , but the issue was that the copyright plugin takes the first line. Also I found that in many projects is the newer year first, probably for the same reason, so finally I had to agree with Arjan.

And another issue - using comma between years is enumerating years in which something new was added. I would prefer rather the minus character, range. Then it would be perfect :-D (but currently I don't know how copyright plugin works with that - last changes I did just added the line with 2022)

[pzygielo]

This discussion repeats - I had the same thoughts as you, @pzygielo , but the issue was that the copyright plugin takes the first line.

This should be resolved in the plugin.
It is not used here though.

And another issue - using comma between years is enumerating years in which something new was added.

https://www.eclipse.org/projects/handbook/#ip-copyright-headers:

The date may optionally be set to a range of years with the first and last years of the range separated by a comma (e.g. “2004, 2017”); in this case, the first year is when the content was first created and the last year is when the content was last modified.

[dmatej]

The date may optionally be set to a range of years with the first and last years of the range separated by a comma (e.g. “2004, 2017”); in this case, the first year is when the content was first created and the last year is when the content was last modified.

Hmm, I see this rule as quite problematic and unusual. But it probably doesn't change anything (meaning in relation to law).

[arjantijms]

This should be resolved in the plugin.

It probably should, too, but at the same time it's still good to have a somewhat standard way of doing this.

Anyway, it was a just a remark. Don't let it hold up the merge. Just something to think about.