Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6432 Applications Take Longer To Deploy on JDK 17 #781

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

jGauravGupta
Copy link
Member

In this PR, a few performance optimizations have been done.

  • The finalize method has been deprecated and removed from FileInputStream, FileOutputStream, Zip Inflator, and Deflator in JDK 12 which may cause resources are not cleaned and leak.
  • File canonicalization cache is disabled by default in JDK 12 which helps in performance optimizations for file name canonicalization. In TypeImpl#addDefiningURI duplicate uri is added so canonicalization is not required.

Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but ECA checker doesn't pass.
Can you check if the email used in the commit is the same as in your Eclipse account?

@arjantijms
Copy link
Contributor

The ECA checks seem to be a global outage at Eclipse. See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2636

@arjantijms arjantijms merged commit 023b592 into eclipse-ee4j:master Feb 6, 2023
@dmatej dmatej added this to the 3.0.4 milestone Mar 27, 2023
@Pandrex247 Pandrex247 mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants