-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using compatible arguments #810
Conversation
Signed-off-by: David Matějček <[email protected]>
For reference: https://maven.apache.org/docs/3.9.0/release-notes.html
Could we keep long-form option and place [possibly indented] profile id in separate line? |
Hmm, what is the advantage of the long form in two lines compared to a single line with the |
Readability. |
I would argue that in this case it would go against readability - the first thing I had to do was to find documentation and check if it is the same or not. Also having to use two lines seems a bit counterintuitive to me. |
Ok, you changed it for your liking while I was thinking about myself.
Hasn't this been the case for |
|
I wanted to wait more for other reponses, but Arjan wants to release GlassFish and I asked him to release HK2 first, so it started to be a quite trivial blocker.
Eclipse.ini doesn't have anything to do with Maven, right? And we are discussing quite trivial problem - long multiline option versus short more often used oneliner.
Yes, but then we also didn't have issues with Maven 3.9.0+ - so if I have to change it, I prefer well known oneliner syntax. |
Fixes
with Maven 3.9.0+