Using compatible arguments

[dmatej]

Fixes

mvn clean install
Unable to parse maven.config file options: Unrecognized option: --activate-profiles staging

with Maven 3.9.0+

[pzygielo]

For reference: https://maven.apache.org/docs/3.9.0/release-notes.html

Each line in .mvn/maven.config is now interpreted as a single argument. That is, if the file contains multiple arguments, these must now be placed on separate lines, see MNG-7684.

Could we keep long-form option and place [possibly indented] profile id in separate line?

[dmatej]

Hmm, what is the advantage of the long form in two lines compared to a single line with the -P which everyone uses locally?

[pzygielo]

Readability.
(e.g. as described https://superuser.com/questions/174564/why-are-there-short-and-long-alternatives-for-command-line-options)

[dmatej]

Readability. (e.g. as described https://superuser.com/questions/174564/why-are-there-short-and-long-alternatives-for-command-line-options)

I would argue that in this case it would go against readability - the first thing I had to do was to find documentation and check if it is the same or not. Also having to use two lines seems a bit counterintuitive to me.

[pzygielo]

I had to do was to find documentation

Ok, you changed it for your liking while I was thinking about myself.

Also having to use two lines seems a bit counterintuitive to me.

Hasn't this been the case for eclipse.ini for years?

[pzygielo]

• And - the long option was introduced with Update dependencies for new servlet 6 to work #679, with no changes requested then.

[dmatej]

Ok, you changed it for your liking while I was thinking about myself.

I wanted to wait more for other reponses, but Arjan wants to release GlassFish and I asked him to release HK2 first, so it started to be a quite trivial blocker.

Hasn't this been the case for eclipse.ini for years?

Eclipse.ini doesn't have anything to do with Maven, right? And we are discussing quite trivial problem - long multiline option versus short more often used oneliner.

And - the long option was introduced with Update dependencies for new servlet 6 to work #679, with no changes requested then.

Yes, but then we also didn't have issues with Maven 3.9.0+ - so if I have to change it, I prefer well known oneliner syntax.