Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues reported by maven when we tried to deploy a pre-release #816

Merged
merged 8 commits into from
Mar 28, 2023
Merged

Fixed issues reported by maven when we tried to deploy a pre-release #816

merged 8 commits into from
Mar 28, 2023

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Mar 28, 2023 •
edited
Loading

  • Originally reported by @arjantijms
  • deprecated javadocs in maven plugins
  • JUnit4 URL changed
  • The maven-osgi dependency is dead, we should get rid of it. Now I replaced it's dependencies by latest, seems it is working
  • spring module had conflicts on classpath

@dmatej
Fixed warnings in hk2-inhabitant-generator
81a886f 
- TBD: see https://issues.apache.org/jira/browse/MJAR-217
- same applies to outputDirectory
- asm.version is managed
- maven-core must have the provided scope

Signed-off-by: David Matějček <[email protected]>
@dmatej
The expression in javadoc is deprecated
c4ffdea 
Signed-off-by: David Matějček <[email protected]>
@dmatej
Fixed OsgiVersionMojo warnings and errors
b9c69e7 
- the exclusion caused javadoc failure on release. It seems it is not required.

Signed-off-by: David Matějček <[email protected]>
@dmatej
Fixed the JUnit4 url
31a48e0 
Signed-off-by: David Matějček <[email protected]>
@dmatej
Fixed plugin dependencies
66163df 
- maven-osgi is dead and brings obsoleted dependencies, but we are able to
  survive that

Signed-off-by: David Matějček <[email protected]>
@dmatej
JDK8 profile is worthless - we use just JDK11+
f9e3872 
Signed-off-by: David Matějček <[email protected]>
@dmatej
Excluded hk2-api dependencies - spring overlaps with the same packages
3020f34 
Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 28, 2023
@dmatej dmatej added this to the 3.0.4 milestone Mar 28, 2023
@dmatej
Updated doclnint configuration
e61844d 
Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej marked this pull request as ready for review March 28, 2023 21:38
@dmatej
Copy link
Contributor Author

dmatej commented Mar 28, 2023

GlassFish passed too:

mvn clean install -Dhk2.version=3.0.4-SNAPSHOT -Dhk2.plugin.version=3.0.4-SNAPSHOT
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15:08 min
[INFO] Finished at: 2023-03-28T23:39:15+02:00
[INFO] ------------------------------------------------------------------------

@dmatej dmatej changed the title Fixed issues reported by @arjantijms when he tried to deploy a pre-release Fixed issues when we tried to deploy a pre-release Mar 28, 2023
@dmatej dmatej changed the title Fixed issues when we tried to deploy a pre-release Fixed issues reported by maven when we tried to deploy a pre-release Mar 28, 2023
@dmatej dmatej mentioned this pull request Mar 28, 2023
Closed
@arjantijms arjantijms merged commit 828057f into eclipse-ee4j:master Mar 28, 2023
@dmatej dmatej deleted the maven branch March 30, 2023 19:05
@dmatej dmatej mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@gerdogdu gerdogdu Awaiting requested review from gerdogdu

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

@pzygielo pzygielo Awaiting requested review from pzygielo

@jGauravGupta jGauravGupta Awaiting requested review from jGauravGupta

@hs536 hs536 Awaiting requested review from hs536

@Tomas-Kraus Tomas-Kraus Awaiting requested review from Tomas-Kraus

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@dmatej @arjantijms