Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop logback dependencies #996

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Mar 8, 2024

These managed dependencies seem to be used only in

<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
</dependency>

But the osgi-adapter-test module was removed from the build anyway
<!-- <module>osgi-adapter-test</module> -->

Even if osgi-adapter-test was included - I could not see logback to transit in other version from anything there.

IF re-including osgi-adapter-test in the build would require logback - we could have it back again then.


@pzygielo pzygielo marked this pull request as ready for review March 8, 2024 09:40
@dmatej
Copy link
Contributor

dmatej commented Mar 8, 2024

Hmmm, I see, will we fix that test?

@pzygielo
Copy link
Contributor Author

pzygielo commented Mar 8, 2024

Hmmm, I see, will we fix that test?

The commit says Removed OSGi adapter tests due to usage of pax-exam - I haven't checked all comments in that PR - is it illegal to use pax-exam? Or was is excluded for other reason? No idea.

@pzygielo pzygielo merged commit 1c355ec into eclipse-ee4j:master Mar 8, 2024
2 checks passed
@pzygielo pzygielo deleted the logback branch March 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants