Skip to content

Commit

Permalink
Prevent connection from being stuck
Browse files Browse the repository at this point in the history
Signed-off-by: jansupol <[email protected]>
  • Loading branch information
jansupol authored and senivam committed Dec 7, 2023
1 parent 8105415 commit 02a869f
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,12 @@ protected void initChannel(SocketChannel ch) throws Exception {
}

// Make the connection attempt.
chan = b.connect(host, port).sync().channel();
try {
chan = b.connect(host, port).sync().channel();
} catch (Exception e) {
responseAvailable.completeExceptionally(e);
return;
}
}

// assert: clientHandler will always notify responseDone: either normally, or exceptionally
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/*
* Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
* version 2 with the GNU Classpath Exception, which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/

package org.glassfish.jersey.netty.connector;

import org.glassfish.jersey.client.ClientConfig;
import org.glassfish.jersey.client.ClientProperties;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import javax.ws.rs.ProcessingException;
import javax.ws.rs.client.ClientBuilder;
import javax.ws.rs.core.Response;

public class ConnectionExceptionTest {
@Test
public void testConnectionException() throws InterruptedException {
Assertions.assertThrows(ProcessingException.class, ()-> {
ClientConfig clientConfig = new ClientConfig();
clientConfig.connectorProvider(new NettyConnectorProvider());

Response r = ClientBuilder.newClient(clientConfig)
.property(ClientProperties.CONNECT_TIMEOUT, 1000)
.property(ClientProperties.READ_TIMEOUT, 1000)
.target("http://test.nonono:8080").request().get();
r.close();
});
}
}

0 comments on commit 02a869f

Please sign in to comment.