Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 java.desktop module dependency #4245

Closed
dconnelly opened this issue Sep 7, 2019 · 2 comments
Closed

Java 11 java.desktop module dependency #4245

dconnelly opened this issue Sep 7, 2019 · 2 comments
Milestone

Comments

@dconnelly
Copy link

Not sure why Jersey should have any dependency on AWT classes, but I am seeing this warning when running a Dropwizard/Jersey app under Java 11:

WARNING: HK2 service reification failed for [org.glassfish.jersey.message.internal.RenderedImageProvider] with an exception:
MultiException stack 1 of 2
java.lang.NoClassDefFoundError: java/awt/image/RenderedImage

We probably should move this provider to a separate maven module, and document that for Java 11+ the 'java.desktop' module would be required for usage.

@dconnelly dconnelly changed the title Java 11 java.desktop dependency Java 11 java.desktop module dependency Sep 7, 2019
@arjantijms
Copy link
Contributor

Maybe it's because of a property converter being used somewhere (this is often used for low level conversions, see e.g. https://arjan-tijms.omnifaces.org/2014/08/high-time-to-standardize-java-ee.html)

That one has an awkward historical dependency on AWT indeed. Many server apps use this one.

@jansupol
Copy link
Contributor

jansupol commented Nov 1, 2019

relates to #4293

@jansupol jansupol added this to the 2.30 milestone Dec 31, 2019
dongjoon-hyun added a commit to apache/spark that referenced this issue Jan 25, 2020
### What changes were proposed in this pull request?

For better JDK11 support, this PR aims to upgrade **Jersey** and **javassist** to `2.30` and `3.35.0-GA` respectively.

### Why are the changes needed?

**Jersey**: This will bring the following `Jersey` updates.
- https://eclipse-ee4j.github.io/jersey.github.io/release-notes/2.30.html
  - eclipse-ee4j/jersey#4245 (Java 11 java.desktop module dependency)

**javassist**: This is a transitive dependency from 3.20.0-CR2 to 3.25.0-GA.
- `javassist` officially supports JDK11 from [3.24.0-GA release note](https://github.com/jboss-javassist/javassist/blob/master/Readme.html#L308).

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins with both JDK8 and JDK11.

Closes #27357 from dongjoon-hyun/SPARK-30639.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants