fix for #4082 #4083
Merged
fix for #4082 #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
requested changes
Mar 21, 2019
|
I was thinking about that and I'm not sure that change is really needed. However it seems to be really weird behavior when framework modifies input from client which is not expected to be modified. And the only reason Jersey does this which I've found is that it tries to avoid NPE when cloning NULL map from input. As a result I've handled possible NULL map in some different way. I've added tests which demonstrates 3 use-cases which can hapend - irrelevant input map (checked and map is still the same). Irrelevant immutable Map (same as previous but the map is explicitly immutable so if there is an attempt to modify it an exception is thrown), NULL input map - works as before (original functionality is kept). |
jansupol
requested changes
Mar 25, 2019
core-common/src/main/java/org/glassfish/jersey/model/internal/ComponentBag.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxim Nesen <[email protected]>
jansupol
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reported issue #4082
Signed-off-by: Maxim Nesen [email protected]