Fixes #4304: ResourceConfig not properly using specified ClassLoader #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kageNamesScanner to load classes
jansupol
reviewed
Oct 29, 2019
| // Workaround because otherwise classes from a different classloader can't be loaded | ||
| if (resourceFinder instanceof PackageNamesScanner) { | ||
| final ClassLoader classLoader = ((PackageNamesScanner) resourceFinder).getClassloader(); | ||
| afl = AnnotationAcceptingListener.newJaxrsResourceAndProviderListener(classLoader); |
There was a problem hiding this comment.
Do not do this when the default ClassLoader:
if (!getClassLoader().equals(classLoader)) {
afl = AnnotationAcceptingListener.newJaxrsResourceAndProviderListener(classLoader);
}
jansupol
reviewed
Oct 29, 2019
| @@ -896,10 +927,11 @@ public boolean isRegistered(final Class<?> componentClass) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| result.addAll(afl.getAnnotatedClasses()); | |||
jansupol
reviewed
Oct 29, 2019
| } | ||
| } | ||
|
|
||
| result.addAll(afl.getAnnotatedClasses()); |
There was a problem hiding this comment.
+result.addAll(parentAfl.getAnnotatedClasses());
|
See Wiki |
Apparently I forgot to add the "Signed off by: *" to the commit. According to the wiki, it needs to be included to every commit I made. What should I do now, because the two commits don't have it, even tho it's signed? EDIT: I guess the easiest would be deleting my fork, doing the changes again but signed off this time and then creating a new PR? |
|
See #4306, sorry again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem (eventually a bug?) in the issue #4304.
Please review, tell me what to change and then eventually merge the PR.
If you won't merge it, I'd like to know why, because I don't wanna maintain my own fork.