Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stacktraces caused by incorrect JNDI lookup #4373

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fixed stacktraces caused by incorrect JNDI lookup #4373

merged 1 commit into from
Feb 19, 2020

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Jan 27, 2020

  • Fixed processing default local interface

    • cause:
      • the stateless bean implemented some interface from library
      • the interface was annotated only with @Path
      • neither interface nor class was annotated by @Local or @Remote (then @Local is implicit in ejb3.2)
  • Implemented support of Stateless.name attribute

    • it is used in JNDI names on Payara
  • Limited default local interfaces

    • partial impl of the ejb 3.2 spec 4.9.7, some interfaces are not allowed

Signed-off-by: David Matejcek [email protected]

* Fixed processing default local interface
  - cause:
    - the stateless bean implemented some interface from library
    - the interface was annotated only with @path
    - neither interface nor class was annotated by @Local or @Remote (then @Local is implicit in ejb3.2)

* Implemented support of Stateless.name attribute
  - it is used in JNDI names on Payara

* Limited default local interfaces
  - partial impl of the ejb 3.2 spec 4.9.7, some interfaces are not allowed

Signed-off-by: David Matejcek <[email protected]>
@dmatej
Copy link
Contributor Author

dmatej commented Jan 27, 2020

Is the failing test stable? Why it failed only on JDK13?
EDIT: passed on my computer with OpenJDK 13.0.2

@jansupol
Copy link
Contributor

This test is intermittently failing, sorry for that, for all JDKs. Should be fixed by #4387.

Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright year in the header to 2020.
It's ok, actually

@senivam senivam merged commit e17b2b1 into eclipse-ee4j:master Feb 19, 2020
@dmatej dmatej deleted the fixed-incorrect-jndi-lookup branch February 20, 2020 09:23
@jansupol jansupol added this to the 2.30.1 milestone Feb 21, 2020
jansupol pushed a commit to jansupol/jersey that referenced this pull request Mar 23, 2020
* Fixed processing default local interface
  - cause:
    - the stateless bean implemented some interface from library
    - the interface was annotated only with @path
    - neither interface nor class was annotated by @Local or @Remote (then @Local is implicit in ejb3.2)

* Implemented support of Stateless.name attribute
  - it is used in JNDI names on Payara

* Limited default local interfaces
  - partial impl of the ejb 3.2 spec 4.9.7, some interfaces are not allowed

Signed-off-by: David Matejcek <[email protected]>
(cherry picked from commit e17b2b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants