Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response.hasEntity to return true if buffered after readEntity #4523

Merged
merged 1 commit into from
Sep 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
* version 2 with the GNU Classpath Exception, which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/

package org.glassfish.jersey.client;

import org.glassfish.jersey.message.internal.InboundMessageContext;
import org.junit.Assert;
import org.junit.Test;

import javax.ws.rs.client.ClientBuilder;
import javax.ws.rs.client.ClientRequestFilter;
import javax.ws.rs.core.Response;
import javax.ws.rs.ext.ReaderInterceptor;
import java.io.InputStream;

public class ClientResponseTest {

@Test
public void testHasEntityWhenNoEntity() {
final InboundMessageContext inboundMessageContext = new InboundMessageContext(new ClientConfig()) {
@Override
protected Iterable<ReaderInterceptor> getReaderInterceptors() {
return null;
}
};

Assert.assertFalse(inboundMessageContext.hasEntity());

inboundMessageContext.bufferEntity();
Assert.assertFalse(inboundMessageContext.hasEntity());
}

@Test
public void testHasEntity() {
final ClientRequestFilter abortFilter = requestContext -> requestContext.abortWith(Response.ok("hello").build());
try (Response r = ClientBuilder.newClient().register(abortFilter).target("http://localhost:8080").request().get()) {
Assert.assertTrue(r.hasEntity());

r.bufferEntity();
Assert.assertTrue(r.hasEntity());

final String s = r.readEntity(String.class);
Assert.assertTrue(r.hasEntity());

final InputStream bufferedEntityStream = r.readEntity(InputStream.class);
Assert.assertNotNull(bufferedEntityStream);
Assert.assertTrue(r.hasEntity());
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ public boolean hasEntity() {
entityContent.ensureNotClosed();

try {
return !entityContent.isEmpty();
return entityContent.isBuffered() || !entityContent.isEmpty();
} catch (IllegalStateException ex) {
// input stream has been closed.
return false;
Expand Down