JDK16 Support #4785
JDK16 Support #4785
Conversation
Signed-off-by: jansupol <[email protected]>
|
|
||
| /* package */ Cache<Class<?>, Boolean> getJaxRsResourceCache() { | ||
| /* CDI injection hack */ | ||
| if (jaxRsResourceCache == null) { |
There was a problem hiding this comment.
Should we synchronize this or are we sure only one thread can invoke it the first time?. Something like:
/* package */ Cache<Class<?>, Boolean> getJaxRsResourceCache() {
/* CDI injection hack */
if (jaxRsResourceCache == null) {
synchronize(this) {
if (jaxRsResourceCache == null) {
jaxRsResourceCache = new Cache<>(clazz -> Resource.from(clazz) != null);
}
}
}
return jaxRsResourceCache;
}
There was a problem hiding this comment.
Nice catch. But invoking this multiple times would not break anything, there would be two instances of the cache & Resource.from would be invoked twice instead of having it used from the cache. I am not sure the double-checked locking is worth it in this case.
There was a problem hiding this comment.
I don't know all the details about how is going to be used, but imagine that there is a singleton that invokes that method and it saves it as a field. So next time it wants to use the cache, it reads it from the field (instead of getting it from getJaxRsResourceCache()).
It will not harm to have that lock because it will only lock at the beginning and we get rid of unnecessary extra memory usage.
There was a problem hiding this comment.
It happens that all the if (jaxRsResourceCache == null) { block is unnecessary, so we could have dropped it
Signed-off-by: jansupol <[email protected]>
Signed-off-by: jansupol [email protected]