Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParamConverters cleanup #4829

Merged
merged 1 commit into from
Jul 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ public class ParamConverterConfigurator implements BootstrapConfigurator {

@Override
public void init(InjectionManager injectionManager, BootstrapBag bootstrapBag) {
InstanceBinding<ParamConverters.AggregatedProvider> aggregatedConverters =
Bindings.service(new ParamConverters.AggregatedProvider(injectionManager))
final ClassBinding<ParamConverters.AggregatedProvider> aggregatedConverters =
Bindings.service(ParamConverters.AggregatedProvider.class)
.to(ParamConverterProvider.class);
injectionManager.register(aggregatedConverters);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ public static class OptionalCustomProvider implements ParamConverterProvider {
// Delegates to this provider when the type of Optional is extracted.
private final InjectionManager manager;

@Inject
public OptionalCustomProvider(InjectionManager manager) {
this.manager = manager;
}
Expand Down Expand Up @@ -405,6 +404,7 @@ public static class AggregatedProvider implements ParamConverterProvider {
/**
* Create new aggregated {@link ParamConverterProvider param converter provider}.
*/
@Inject
public AggregatedProvider(InjectionManager manager) {
this.providers = new ParamConverterProvider[] {
// ordering is important (e.g. Date provider must be executed before String Constructor
Expand Down