NettyConnectorProvider (jersey-netty-connector) is throwing an except… #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion with inactive_pooled_connection_handler error Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
reviewed
Sep 13, 2021
| } else { | ||
| try { | ||
| // Remove it only if the channel is open. Otherwise there are no such names and it fails. | ||
| chan.pipeline().remove(INACTIVE_POOLED_CONNECTION_HANDLER); |
There was a problem hiding this comment.
I'd prefer this not to be in else block and try to do this no matter the chan.isOpen or not.
There was a problem hiding this comment.
I was not very happy about eating one exception, so I tried to minimize the frequency that it happens. But yes, anyway we need to eat it.
| } | ||
|
|
||
| // This test is for debugging purposes. By default it works with and without the fix. | ||
| @Test |
There was a problem hiding this comment.
I am not in favor of adding this file to the project.
- The file brings in additional dependency
- The test passes either way. The comment suggests it is for debugging purposes, but the usage is doubtful.
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
approved these changes
Sep 17, 2021
senivam
approved these changes
Sep 17, 2021
This was referenced Jun 14, 2022
Closed
1 task
This was referenced Jun 18, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Nov 30, 2023
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4851