Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of deprecated beanManager.createInjectionTarget #4933

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Replace usage of deprecated beanManager.createInjectionTarget #4933

merged 1 commit into from
Dec 15, 2021

Conversation

arjantijms
Copy link
Contributor

The BeanManager.createInjectionTarget is deprecated since CDI 1.1 and has been removed in CDI 4. Calling it will result in exceptions when using CDI 4.

Signed-off-by: arjantijms [email protected]

senivam
senivam approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Regarding #4934 I would rather merge this PR to the 3.1 branch after it's in master (with respect to jakarta related changes), but since the work is already done, the #4934 could be merged directly into the 3.1 branch (conflicts with occasional master merge would be resolved in that case).

@arjantijms
Copy link
Contributor Author

@senivam It should hopefully be alright, as I already cherrypicked it and then resolved the conflicts. Hopefully git is smart enough to see it has already been merged.

jansupol
jansupol approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arjan

@senivam
Copy link
Contributor

senivam commented Dec 15, 2021

@arjantijms Great then, thanks :)

@senivam senivam merged commit bdb0dd0 into eclipse-ee4j:master Dec 15, 2021
@senivam senivam added this to the 2.36 milestone Jan 3, 2022
This was referenced Jun 14, 2022
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Open
@ChristianHoesel ChristianHoesel mentioned this pull request Jun 15, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 18, 2022
Open
1 task
@renovate renovate bot mentioned this pull request Dec 22, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
Closed
This was referenced Feb 11, 2023
Merged
Closed
@renovate renovate bot mentioned this pull request Mar 23, 2023
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 26, 2023
Open
This was referenced May 11, 2023
Open
Open
This was referenced Jun 1, 2023
Merged
Closed
This was referenced Jun 4, 2023
Merged
Closed
This was referenced Jun 15, 2023
Merged
Merged
This was referenced Jun 26, 2023
Closed
Open
This was referenced Jul 6, 2023
Open
Open
This was referenced Aug 28, 2023
Merged
Merged
This was referenced Nov 30, 2023
Closed
Closed
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
@renovate renovate bot mentioned this pull request Mar 1, 2024
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 24, 2024
Open
1 task
This was referenced Apr 13, 2024
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansupol jansupol jansupol approved these changes

@senivam senivam senivam approved these changes

@dmatej dmatej Awaiting requested review from dmatej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.36
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arjantijms @senivam @jansupol