Blocked thread if WebApplicationException is reused. #4097 #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
The test for context.isCommitted() may seem to be too much, we may only restrict the responses with entity (context.hasEntity() == true ). But then, the same issue can occur with for instance headers, when the header value is an inputstream for instance. Hence restricting all Responses seems like a proper way to go.
| @@ -71,6 +71,7 @@ error.resources.cannot.merge=Resources do not have the same path and cannot be m | |||
| error.request.abort.in.response.phase=The request cannot be aborted as it is already in the response processing phase. | |||
| error.request.set.entity.stream.in.response.phase=The entity stream cannot be set in the request as it is already in the response processing phase. | |||
| error.request.set.security.context.in.response.phase=The security context cannot be set in the request as it is already in the response processing phase. | |||
| error.response.already.commited=Response was already committed. This response is being reused more than 1 time. | |||
There was a problem hiding this comment.
The response entity was already committed. The Response entity is being reused more than once.
Is it more explanatory to users? Maybe not that much correct, though.
|
|
||
| @Override | ||
| protected TestContainerFactory getTestContainerFactory() throws TestContainerException { | ||
| return new JdkHttpServerTestContainerFactory(); |
There was a problem hiding this comment.
The default TestContainerFactory seems to work as well.
Signed-off-by: Jorge Bescos Gascon <[email protected]>
senivam
approved these changes
Apr 25, 2022
This was referenced Jun 14, 2022
Closed
1 task
This was referenced Jun 18, 2022
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Nov 30, 2023
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4097
To fix the blocked thread issue, it is only necessary the changes in class ResponseWriter
The other changes are related to fail with 500 when the response is reused more than 1 time.