Netty Connector doesn't support Followredirects #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbescos
force-pushed
the
issue5045
branch
2 times, most recently
from
d09bbb1
to
cde8346
Compare
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
approved these changes
May 12, 2022
| @@ -46,21 +49,27 @@ | |||
| */ | |||
| class JerseyClientHandler extends SimpleChannelInboundHandler<HttpObject> { | |||
|
|
|||
| private static final String LOCATION_HEADER = "Location"; | |||
There was a problem hiding this comment.
javax.ws.rs.core.HttpHeaders.Location
|
Thanks for the comments, I will work on that. I was not aware about the redirect handler, and it looks I should use it. |
jbescos
force-pushed
the
issue5045
branch
4 times, most recently
from
b37494b
to
70a9896
Compare
jansupol
reviewed
May 13, 2022
| * @see org.glassfish.jersey.client.ClientProperties#FOLLOW_REDIRECTS | ||
| * @see org.glassfish.jersey.netty.connector.internal.RedirectException | ||
| */ | ||
| public static final String MAX_REDIRECTS = "jersey.config.client.NettyConnectorProvider.maxRedirects"; |
There was a problem hiding this comment.
Could you please update the properties documentation?
There was a problem hiding this comment.
Yes, lets wait for a green build just in case I did something wrong.
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
approved these changes
May 17, 2022
senivam
approved these changes
May 17, 2022
This was referenced Jun 14, 2022
Closed
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Nov 30, 2023
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5045