Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For OSGi services lookup use only classes assignable from service class #5051

Merged
merged 3 commits into from
May 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2019 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -115,7 +115,7 @@ public <T> Iterator<T> createIterator(
final ClassLoader loader,
final boolean ignoreOnClassNotFound) {

final List<Class<?>> providerClasses = locateAllProviders(serviceName);
final List<Class<?>> providerClasses = locateAllProviders(serviceClass);
if (!providerClasses.isEmpty()) {
return new Iterator<T>() {

Expand Down Expand Up @@ -153,7 +153,7 @@ public void remove() {
@Override
public <T> Iterator<Class<T>> createClassIterator(
final Class<T> service, final String serviceName, final ClassLoader loader, final boolean ignoreOnClassNotFound) {
final List<Class<?>> providerClasses = locateAllProviders(serviceName);
final List<Class<?>> providerClasses = locateAllProviders(service);
if (!providerClasses.isEmpty()) {
return new Iterator<Class<T>>() {

Expand Down Expand Up @@ -552,14 +552,22 @@ private void register(final Bundle bundle) {
}
}

private List<Class<?>> locateAllProviders(final String serviceName) {
private List<Class<?>> locateAllProviders(final Class<?> serviceClass) {
lock.readLock().lock();
try {
final List<Class<?>> result = new LinkedList<Class<?>>();
for (final Map<String, Callable<List<Class<?>>>> value : factories.values()) {
if (value.containsKey(serviceName)) {
if (value.containsKey(serviceClass.getName())) {
try {
result.addAll(value.get(serviceName).call());
for (final Class<?> clazz : value.get(serviceClass.getName()).call()) {
if (serviceClass.isAssignableFrom(clazz)) {
result.add(clazz);
} else if (LOGGER.isLoggable(Level.FINER)) {
LOGGER.log(Level.FINER,
"Ignoring provider class " + clazz.getName() + " because it is not assignable to "
+ " service class " + serviceClass.getName());
}
}
jansupol marked this conversation as resolved.
Show resolved Hide resolved
} catch (final Exception ex) {
// ignore
}
Expand Down