Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GSON media #5090

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Support GSON media #5090

merged 4 commits into from
Jul 21, 2022

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jun 21, 2022

Support GSON in Jersey

@senivam
Copy link
Contributor

senivam commented Jun 21, 2022

CQ 24148

@senivam
Copy link
Contributor

senivam commented Jun 21, 2022

CI build for now fails with technical error. The related issue is filled 1447

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@senivam
Copy link
Contributor

senivam commented Jun 21, 2022

bug 1447 which was being solved via the bug 1443 seems to be resolved - the git tool is back again, so CI builds are being processed right now.

@jansupol
Copy link
Contributor

@jbescos Thank you for the PR.

The advantage of Gson is the ability to work with org.json.JSONObject. Can you please add a test demonstrating the usage of this json.org API?

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Copy link
Member Author

jbescos commented Jul 1, 2022

@jbescos Thank you for the PR.

The advantage of Gson is the ability to work with org.json.JSONObject. Can you please add a test demonstrating the usage of this json.org API?

Sure, I have added that in this commit:
26a7eff

@jansupol
Copy link
Contributor

jansupol commented Jul 1, 2022

I have tried to submit CQ for org.json. Unfortunately, the license is not compatible with the Eclipse Foundation rules.
See CQ 20330. I checked the latest release, the problematic clause is still there.

I am sorry I asked for the additional test for JSONObject, that additional commit needs to go off. Can you please update the PR?

@jbescos
Copy link
Member Author

jbescos commented Jul 1, 2022

I have tried to submit CQ for org.json. Unfortunately, the license is not compatible with the Eclipse Foundation rules. See CQ 20330. I checked the latest release, the problematic clause is still there.

I am sorry I asked for the additional test for JSONObject, that additional commit needs to go off. Can you please update the PR?

No worries, I have reverted it

@jbescos jbescos force-pushed the gson branch 2 times, most recently from a602bf5 to e1e9913 Compare July 11, 2022 06:12
@jbescos
Copy link
Member Author

jbescos commented Jul 15, 2022

It looks the build gets hanged after the maven command:

[INFO] jersey-examples-moxy ............................... SUCCESS [  2.935 s]
[INFO] jersey-test-framework-maven-custom-enforcer-rules .. SUCCESS [  3.062 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  58:07 min
[INFO] Finished at: 2022-07-11T07:11:20Z
[INFO] ------------------------------------------------------------------------
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] }

This reverts commit 26a7eff.

Signed-off-by: Jorge Bescos Gascon <[email protected]>
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listed CQ is approved. LGTM

Signed-off-by: Jorge Bescos Gascon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants