Change JettyConnector 'readTimeout' behavior to match socket read tim… #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout definition - e.g., ApacheConnector behavior matches it. * Read timeout: Time on waiting to receive the first data byte. The `timeout` method timeouts the request even if data were already received, capping the query to a maximum execution time. This behavior is problematic when streaming data over a prolonged duration; the client has already received data bytes, but data continues to flow. I provided a jetty specific property (jersey.config.jetty.client.totalTimeout) that configures the 'totalTimeout' when required.
jbescos
reviewed
Aug 8, 2022
| @@ -314,8 +314,14 @@ private Request translateRequest(final ClientRequest clientRequest) { | |||
| request.followRedirects(clientRequest.resolveProperty(ClientProperties.FOLLOW_REDIRECTS, true)); | |||
| final Object readTimeout = clientRequest.resolveProperty(ClientProperties.READ_TIMEOUT, -1); | |||
| if (readTimeout != null && readTimeout instanceof Integer && (Integer) readTimeout > 0) { | |||
| request.timeout((Integer) readTimeout, TimeUnit.MILLISECONDS); | |||
| request.idleTimeout((Integer) readTimeout, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
Javadoc does not say much about this, but I think this does not exactly have the same meaning than read time out. This method should also have impact in writing (not only read).
However there is no such method to set a read timeout, and this is more correct than before, so it looks good to me.
There was a problem hiding this comment.
Javadoc does not say much about this, but I think this does not exactly have the same meaning than read time out. > This method should also have impact in writing (not only read).
You are right. the timeout may fire when there is a long enough pause during data transfer. I don't know to be honest.
As you say, the situation seems better like this anyway.
jansupol
approved these changes
Sep 2, 2022
This was referenced Sep 6, 2022
1 task
This was referenced Sep 8, 2022
This was referenced Sep 18, 2022
This was referenced Sep 25, 2022
This was referenced Oct 19, 2022
1 task
This was referenced Dec 7, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Nov 30, 2023
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eout definition - e.g., ApacheConnector behavior matches it.
The
timeoutmethod timeouts the request even if data were already received, capping the query to a maximum execution time.This behavior is problematic when streaming data over a prolonged duration; the client has already received data bytes, but data continues to flow.
I provided a jetty specific property (jersey.config.jetty.client.totalTimeout) that configures the 'totalTimeout' when required.