Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSLHandshake No appropriate protocol (protocol is disabled or cipher suites are inappropriate) #5198

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Nov 16, 2022

TLS 1.0 and TLS 1.1 are deprecated, and in some updated JDKs tests are failing.

…suites are inappropriate)

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@senivam
Copy link
Contributor

senivam commented Nov 18, 2022

I would advise checking if those protocols are supported in the given environment, something like

final SSLContext context = SSLContext.getInstance("TLS");
        context.init(null, null, null);
        final String[] supportedProtocols = context.getDefaultSSLParameters().getProtocols();
        if (Arrays.toString(supportedProtocols).contains("TLSv1.1")) {
           System.setProperty("jdk.tls.server.protocols", "TLSv1.1");
           System.setProperty("jdk.tls.client.protocols", "TLSv1.1");
        }

… cipher suites are inappropriate)"

This reverts commit e154e23.

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Copy link
Member Author

jbescos commented Nov 18, 2022

I would advise checking if those protocols are supported in the given environment, something like

final SSLContext context = SSLContext.getInstance("TLS");
        context.init(null, null, null);
        final String[] supportedProtocols = context.getDefaultSSLParameters().getProtocols();
        if (Arrays.toString(supportedProtocols).contains("TLSv1.1")) {
           System.setProperty("jdk.tls.server.protocols", "TLSv1.1");
           System.setProperty("jdk.tls.client.protocols", "TLSv1.1");
        }

Done

Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@senivam senivam merged commit 45f0699 into eclipse-ee4j:master Dec 1, 2022
@senivam senivam added this to the 2.38 milestone Dec 1, 2022
This was referenced Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants