Return null instead of throwing exception when querystring parameter is missing #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of throwing IllegalArgumentException when value is null, just return null. - Throwing exceptions is expensive, especially when it's done for every querystring parameter that has no `@DefaultValue` (and is not present in the request querystring)
|
I'm working with legal to get the eca signed. |
|
Closed in favor of #5326. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5260
@DefaultValue(and is not present in the request querystring)I'm still looking for a good place to add a unit test. Would
ParamConverterInternalTestbe it?