-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JerseyEventSink#send throwing non IOExceptions #5490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
senivam
approved these changes
Dec 6, 2023
jansupol
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to backported to 2.x, too
1 task
This was referenced Dec 15, 2023
Merged
This was referenced Dec 24, 2023
This was referenced Jan 2, 2024
1 task
1 task
1 task
1 task
This was referenced Dec 12, 2023
This was referenced Mar 7, 2024
This was referenced Mar 18, 2024
1 task
Open
1 task
1 task
1 task
This was referenced Jul 9, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to jakartaee/rest#1196
Maybe we should catch Throwable instead of Exception.
I don't know what was the reason to catch only IOExceptions, but in the case of Helidon a runtime exception is thrown:
java.io.UncheckedIOException: java.net.SocketException: Broken pipe
Anyway, as it returns a
CompletionStage
I think we should not throw exceptions inJerseyEventSink#send
.Also UncheckedIOException is caught in ChunkedOutput