Add ability to configure the queue capacity for ChunkedOutput #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding constructor which sets the queue capacity. This allows for calling write from different threads until the queue is full. Subsequent write calls will block until the queue is emptied. This change allows to prevent memory issues in case of slow clients. Basically, a backpressure mechanism based on the queue size.
|
I will put in a new PR under a different account for the ECA. |
|
Replaced by #5621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding constructor which sets the queue capacity.
This allows for calling write from different threads until the queue is full. Subsequent write calls will block until the queue is emptied.
This change allows to prevent memory issues in case of slow clients. Basically, a backpressure mechanism based on the queue size.
This change provides a way to call write on ChunkedOutput from multiple threads to improve throughput, while preventing memory issues in case of slow clients. The queue is bounded and thus cannot grow endlessly.