-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to configure the queue capacity for ChunkedOutput #5621
Merged
senivam
merged 24 commits into
eclipse-ee4j:2.x
from
rutterpaul-personal:maintenance/chunkedoutput-configure-queue-size
Apr 25, 2024
Merged
Add ability to configure the queue capacity for ChunkedOutput #5621
senivam
merged 24 commits into
eclipse-ee4j:2.x
from
rutterpaul-personal:maintenance/chunkedoutput-configure-queue-size
Apr 25, 2024
Commits on Apr 23, 2024
-
Adding constructors which sets the queue capacity. This allows for calling write from different threads until the queue is full. Subsequent write calls will block until the queue is emptied. This change allows to prevent memory issues in case of slow clients. Basically, a backpressure mechanism based on the queue size. This change provides a way to call write on ChunkedOutput from multiple threads to improve throughput, while preventing memory issues in case of slow clients. The queue is bounded and thus cannot grow endlessly.
Configuration menu - View commit details
-
Copy full SHA for 9a58a6f - Browse repository at this point
Copy the full SHA 9a58a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5176818 - Browse repository at this point
Copy the full SHA 5176818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9069a05 - Browse repository at this point
Copy the full SHA 9069a05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b77b7 - Browse repository at this point
Copy the full SHA 95b77b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a91c120 - Browse repository at this point
Copy the full SHA a91c120View commit details -
Add chunkType, String by default.
Configuration menu - View commit details
-
Copy full SHA for df15d68 - Browse repository at this point
Copy the full SHA df15d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 270210e - Browse repository at this point
Copy the full SHA 270210eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aa9218 - Browse repository at this point
Copy the full SHA 2aa9218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3428f2b - Browse repository at this point
Copy the full SHA 3428f2bView commit details -
Update ChunkedInputOutputTest.java
Add e2e test that uses builder with queue capacity of 2.
Configuration menu - View commit details
-
Copy full SHA for 5fefe35 - Browse repository at this point
Copy the full SHA 5fefe35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 383a883 - Browse repository at this point
Copy the full SHA 383a883View commit details -
Update documentation with an example of the builder with the capacity
Configuration menu - View commit details
-
Copy full SHA for 370bde2 - Browse repository at this point
Copy the full SHA 370bde2View commit details -
Configuration menu - View commit details
-
Copy full SHA for baaae71 - Browse repository at this point
Copy the full SHA baaae71View commit details -
Make chunkType a required argument to the builder. Change builder methods.
Configuration menu - View commit details
-
Copy full SHA for e15ab82 - Browse repository at this point
Copy the full SHA e15ab82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14cd830 - Browse repository at this point
Copy the full SHA 14cd830View commit details -
Configuration menu - View commit details
-
Copy full SHA for 673b088 - Browse repository at this point
Copy the full SHA 673b088View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b436843 - Browse repository at this point
Copy the full SHA b436843View commit details -
Add two builders, one with and one without type.
Configuration menu - View commit details
-
Copy full SHA for 6fb8775 - Browse repository at this point
Copy the full SHA 6fb8775View commit details -
Configuration menu - View commit details
-
Copy full SHA for da8bbbe - Browse repository at this point
Copy the full SHA da8bbbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e2d1f0 - Browse repository at this point
Copy the full SHA 6e2d1f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8dba05 - Browse repository at this point
Copy the full SHA d8dba05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5827f67 - Browse repository at this point
Copy the full SHA 5827f67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 318610f - Browse repository at this point
Copy the full SHA 318610fView commit details -
Drain queue on exception, to prevent deadlock in threads waiting on the queue to be drained while an exception occurred.
Configuration menu - View commit details
-
Copy full SHA for 86e4a50 - Browse repository at this point
Copy the full SHA 86e4a50View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.