Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for semantic tokens from LSP 3.16 #430

Closed
ericdallo opened this issue Jun 20, 2020 · 5 comments · Fixed by #446
Closed

Support for semantic tokens from LSP 3.16 #430

ericdallo opened this issue Jun 20, 2020 · 5 comments · Fixed by #446
Milestone
v0.10.0

Comments

@ericdallo
Copy link
Contributor

New Semantic tokens feature: https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/#version_3_16_0

More info on protocol here: https://github.com/microsoft/vscode-languageserver-node/blob/master/protocol/src/common/protocol.semanticTokens.proposed.ts
@ericdallo ericdallo changed the title Support for smenatic tokens from LSP 3.16 Support for semantic tokens from LSP 3.16 Jun 20, 2020
@ericdallo ericdallo mentioned this issue Jun 20, 2020
Closed
@kdbeall
Copy link

kdbeall commented Jul 15, 2020 •
edited
Loading

@ericdallo Any updates? Excited to see this in language server protocol!

@ericdallo
Copy link
Contributor Author

@kdbeall Actually I opened this issue to track this feature, but I don't know if someone will implement it as LSP 3.16 is not released yet

@kdbeall
Copy link

kdbeall commented Jul 21, 2020 •
edited
Loading

Ah, okay! I may be able to try and explore adding support for this at some point, but I cannot make a promise.

@kdbeall
Copy link

kdbeall commented Jul 28, 2020 •
edited
Loading

@spoenemann @svenefftinge @jonahgraham Have there been any efforts for semantic tokens?

@spoenemann
Copy link
Contributor

No, not yet. Contributions are welcome!

@ericdallo ericdallo mentioned this issue Aug 30, 2020
Merged
@spoenemann spoenemann added this to the v0.10.0 milestone Oct 7, 2020
adietish pushed a commit to adietish/lsp4j that referenced this issue Aug 20, 2024
@angelozerr
fix: LSP textDocument/definition doens't open the file when range start
bcf63b3 
/ end are equals

Fixes eclipse-lsp4j#430

Signed-off-by: azerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Add support for semanticTokens
3 participants
@spoenemann @ericdallo @kdbeall