-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codicon color and URI support to TerminalOptions #13413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of initial high-level comments.
@tsmaeder |
f228b09
to
6f852a8
Compare
@dhuebner the license check fails. Do we need an ip ticket here? |
54f956b
to
0208720
Compare
0208720
to
9b2fb2e
Compare
9b2fb2e
to
461c33e
Compare
@dhuebner @tsmaeder I've updated the PR myself. I've added support for custom icons for quick pick items and quick pick buttons. You can find an example plugin for that here. Simply use the |
93d842d
to
37592d0
Compare
@msujew ![]() I noticed that after reloading the host, custom terminal (restored) icons are not rendered, see below. ![]() |
Partial close of 12074 - This commit adds URI and { light, dark } support for terminal icons. - This commit adds ColorTheme support for ThemeIcons - Support for `ExtensionTerminalOptions#iconPath` Signed-Off-By: FernandoAscencio <[email protected]> (cherry picked from commit ba3dda2)
b08b517
to
76cb0ae
Compare
@JonasHelming I (re)wrote most of this PR. I'm not in a good position to review it. I already pinged @tsmaeder for a review. |
It's on my list of todo's. |
@msujew how do I test this? Where do the icons show up? |
For the quick pick icons:
For the terminal icons: You need to install the linked plugin and run the associated commands. For example |
@msujew What is the state of this, ready for a re-review? |
This is a copy of the original PR #12861
First commit was cherry picked from FernandoAscencio@ba3dda2
In the second commit, I applied the suggested changed from the original PR.
The original description below
What it does
Closes #12074
This commit adds URI and { light, dark } support for terminal icons.
This commit adds ColorTheme support for ThemeIcons
Support for ExtensionTerminalOptions#iconPath
How to test
Open Theia
Install from VSIX the test extension
Check the result follow VSCode test results seen below:
VSCode test Results
![TerminalIconTests](https://private-user-images.githubusercontent.com/48699277/263130762-fe36b9c4-9ea8-450f-8d36-6dfa165f85ff.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MzA3NjEsIm5iZiI6MTcyNTczMDQ2MSwicGF0aCI6Ii80ODY5OTI3Ny8yNjMxMzA3NjItZmUzNmI5YzQtOWVhOC00NTBmLThkMzYtNmRmYTE2NWY4NWZmLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE3MzQyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Nzg2Mzg3YjU2NWM4N2ZiN2QyZWJkYmFjNjEyYTQ4OTFjYTI5ODY4YmUzY2E4MmFiNzU3NWU5ZTdkYmJiOWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2nHZh4JZXOfZDEUkqJqA37IfbTl0c_L6xsaMc102mkE)
![TerminalIconTestsLight](https://private-user-images.githubusercontent.com/48699277/263130796-ea7f19ca-f685-493e-b011-20723b88b5f7.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MzA3NjEsIm5iZiI6MTcyNTczMDQ2MSwicGF0aCI6Ii80ODY5OTI3Ny8yNjMxMzA3OTYtZWE3ZjE5Y2EtZjY4NS00OTNlLWIwMTEtMjA3MjNiODhiNWY3LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE3MzQyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0YWU3YTlkMTI2ZDQzNGY4YzYyYjQ5YmFjMTMwNDIwNmJmNzhjNDE1YWJkNDRlMTk4NDIzNWM4NzY2ZGU3YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YRuH_hvZWqSU3GdtCyuMvhjae4KorO-gD_xtPS1srP4)
Dark
Light
Review checklist
Reminder for reviewers