Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codicon color and URI support to TerminalOptions #13413

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Feb 22, 2024

This is a copy of the original PR #12861
First commit was cherry picked from FernandoAscencio@ba3dda2
In the second commit, I applied the suggested changed from the original PR.

The original description below

What it does

Closes #12074

This commit adds URI and { light, dark } support for terminal icons.
This commit adds ColorTheme support for ThemeIcons
Support for ExtensionTerminalOptions#iconPath

How to test

Open Theia
Install from VSIX the test extension
Check the result follow VSCode test results seen below:

VSCode test Results
Dark
TerminalIconTests
Light
TerminalIconTestsLight

Review checklist

Reminder for reviewers

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of initial high-level comments.

packages/terminal/src/browser/base/terminal-widget.ts Outdated Show resolved Hide resolved
packages/plugin-ext/src/plugin/terminal-ext.ts Outdated Show resolved Hide resolved
packages/terminal/src/browser/terminal-widget-impl.ts Outdated Show resolved Hide resolved
@JonasHelming JonasHelming removed the request for review from rschnekenbu March 22, 2024 07:46
@dhuebner
Copy link
Contributor Author

@tsmaeder
Thanks for your re-view, I will have a look today.

@tsmaeder
Copy link
Contributor

@dhuebner the license check fails. Do we need an ip ticket here?

@dhuebner
Copy link
Contributor Author

@tsmaeder
It hard to say for me what exactly fails from reading the error log.
The original PR, however, didn't fail #12861
And I added no additional dependencies.

@rschnekenbu
Copy link
Contributor

@dhuebner, there was a message yesterday from Thomas on Theia dev list about those IP checks failing. You may rebase on top of master, that should fix the issue. #13524 is the PR fixing the issue.

@msujew
Copy link
Member

msujew commented May 27, 2024

@dhuebner @tsmaeder I've updated the PR myself. I've added support for custom icons for quick pick items and quick pick buttons. You can find an example plugin for that here. Simply use the Quick Input Samples command. Use the multiStepInput option to test that the button icons work as expected. With that I was able to align the icon code of terminals and quick picks.

@dhuebner
Copy link
Contributor Author

dhuebner commented Jun 14, 2024

@msujew
After properly rebuilding the local state it works for me!

Bildschirmfoto 2024-06-14 um 13 52 27

I noticed that after reloading the host, custom terminal (restored) icons are not rendered, see below. Also the default terminal Terminal 5 doesn't have an Icon, should we use the default icon here?
I've added a default icon for the shell terminals.

Bildschirmfoto 2024-06-14 um 13 50 49

FernandoAscencio and others added 7 commits June 14, 2024 14:46
Partial close of 12074

- This commit adds URI and { light, dark } support for terminal icons.
- This commit adds ColorTheme support for ThemeIcons
- Support for `ExtensionTerminalOptions#iconPath`

Signed-Off-By: FernandoAscencio <[email protected]>
(cherry picked from commit ba3dda2)
@msujew
Copy link
Member

msujew commented Jun 20, 2024

@JonasHelming I (re)wrote most of this PR. I'm not in a good position to review it. I already pinged @tsmaeder for a review.

@tsmaeder
Copy link
Contributor

It's on my list of todo's.

@tsmaeder
Copy link
Contributor

@msujew how do I test this? Where do the icons show up?

@msujew
Copy link
Member

msujew commented Jun 20, 2024

@tsmaeder

For the quick pick icons:

You can find an example plugin for that here. Simply use the Quick Input Samples command. Use the multiStepInput option to test that the button icons work as expected.

For the terminal icons: You need to install the linked plugin and run the associated commands. For example Green File Codicon Icon Terminal (they all end on Terminal).

@JonasHelming
Copy link
Contributor

@msujew What is the state of this, ready for a re-review?

@msujew msujew requested a review from tsmaeder June 26, 2024 09:29
@msujew msujew merged commit 9ae7640 into eclipse-theia:master Jun 27, 2024
14 checks passed
@msujew msujew added terminal issues related to the terminal vscode issues related to VSCode compatibility quick-open issues related to the quick-open labels Jun 27, 2024
@dhuebner dhuebner deleted the huebner/terminalURI branch June 28, 2024 06:58
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vscode: Missing partial icon and color API support for ExtensionTerminalOptions and TerminalOptions
7 participants