Use 'openWithSystemApp' to open uri when 'env.openExternal' requested #13676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuebner
force-pushed
the
dhuebner/externalAppOpener-13535
branch
from
e0061c5
to
ac9b2c4
Compare
dhuebner
force-pushed
the
dhuebner/externalAppOpener-13535
branch
from
ac9b2c4
to
1eb22ea
Compare
rschnekenbu
approved these changes
Jun 24, 2024
|
Note: I tested on a rebase of the current branch on master, to check on latest master. It took me a long time to be able to review this one :/ |
|
@rschnekenbu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When
vscode.env.openExternalis requested, opens the URI usingwindow.electronTheiaCore.openWithSystemAppinstead of opening the file in the default Theia editor.See #13535
How to test
Follow the "Steps to Reproduce" instructions in #13535
Follow-ups
Review checklist
Reminder for reviewers