Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor preference tree layouting #13819

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Refactor preference tree layouting #13819

merged 6 commits into from
Jul 3, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 17, 2024

What it does

Closes #13802
Supersedes #12929

Adds a new PreferenceLayoutProvider service that allows us to translate preference tree items. Also reuses some code from #12929 to correctly display plugin configuration groups in the settings widget.

How to test

  1. Start Theia and confirm that the preference tree behaves as in VS Code.
  2. Install a language pack and assert that the preference tree is localized.
  3. Assert that preferences from the TypeScript extension are displayed as TypeScript and not Typescript and Javascript.

Review checklist

Reminder for reviewers

@msujew msujew added preferences issues related to preferences vscode issues related to VSCode compatibility localization issues related to localization/internalization/nls labels Jun 17, 2024
@tsmaeder
Copy link
Contributor

If I understand this correctly, the additional NLS is only happening for section titles, not the leaf configuration properties themselves?

@tsmaeder
Copy link
Contributor

I also seems really smelly that the preferences tree knows about preferences for all kinds of Theia extensions (like scm) which may not even be present in a Theia-based product. Are we doing this to simulate the same appearance as VS Code?

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, just some comments on the code.

@msujew msujew requested a review from tsmaeder July 2, 2024 16:00
@msujew msujew merged commit 5a8d3cf into master Jul 3, 2024
11 of 14 checks passed
@msujew msujew deleted the msujew/settings-nls branch July 3, 2024 10:52
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The settings page does not support internationalization
2 participants