-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor preference tree layouting #13819
Conversation
If I understand this correctly, the additional NLS is only happening for section titles, not the leaf configuration properties themselves? |
I also seems really smelly that the preferences tree knows about preferences for all kinds of Theia extensions (like scm) which may not even be present in a Theia-based product. Are we doing this to simulate the same appearance as VS Code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised, just some comments on the code.
112700e
to
a82458d
Compare
What it does
Closes #13802
Supersedes #12929
Adds a new
PreferenceLayoutProvider
service that allows us to translate preference tree items. Also reuses some code from #12929 to correctly display plugin configuration groups in the settings widget.How to test
TypeScript
and notTypescript
andJavascript
.Review checklist
Reminder for reviewers