-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data race in problem view tree #13841
Conversation
@msujew When I open the directory with the rust test code ("Open Folder"), I get an error in the browser log (Electron)
|
Playwright tests have the same problem. |
@tsmaeder Yep, sorry. Wanted to be too smart about type checking, which led to surprising runtime errors. Weird that TypeScript didn't catch that actually. |
@msujew I get an error dialog when starting up. Is this relevent?
|
@tsmaeder This should be fixed with #13825, which isn't included in this PR yet. Let me quickly rebase this. Alternatively you can just manually download the correct version for your OS from open-vsx. |
d8f8655
to
be55d2a
Compare
@msujew the rust language server still complains about some toolchain not being setup correctly:
Is there some additional setup required? |
@tsmaeder The rust analyzer requires the |
What it does
Closes #13750
Closes #13835
Whenever we encounter a new diagnostics collection for a given file (i.e. the diagnostics have been updated/replaced), we now simply replace the still waiting collection in the map. This ensures that the problem view tree stays consistent and outdated diagnostics get correctly replaced.
How to test
Run the test steps from #13835 and assert that everything works as expected.
Review checklist
Reminder for reviewers