Add DebugSessionOptions.testRun #13939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the extension And here's the source code: |
rschnekenbu
approved these changes
Jul 22, 2024
| @@ -62,7 +62,10 @@ export class TestRunViewContribution extends AbstractViewContribution<TestRunTre | |||
| override registerCommands(commands: CommandRegistry): void { | |||
| super.registerCommands(commands); | |||
| commands.registerCommand(TestViewCommands.CANCEL_RUN, { | |||
| isEnabled: t => TestRun.is(t) && t.isRunning, | |||
| isEnabled: t => { | |||
| console.log('is enabled'); | |||
There was a problem hiding this comment.
Probably a leftover from debugging?
Fixes eclipse-theia#13872 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
force-pushed
the
13872_test_run_option
branch
from
29e1232
to
5dd778f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds the
DebugSessionOptions.testRunfield. The behavioral change associated with this is that a debug session that is started as part of test run will be terminated when the test run ends.Fixes #13872
Contributed on behalf of STMicroelectronics
How to test
The attached plugin contributes a test controller with a single test.
Follow-ups
Review checklist
Reminder for reviewers