[chore] downgrade jsdom to 22.1.0 #13944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschnekenbu
requested review from
martin-fleck-at
and removed request for
martin-fleck-at
|
This PR is on hold until a decision was reached whether to deprecate Node 16 support or not, see #13943. |
|
@martin-fleck-at we can't ship a release that does not build on our documented platforms. |
msujew
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13943
This is a downgrade on jsdom library recently uplifted, because of the current minimal requirement to node 18.
jsdom 22.1.0 is the latest version of jsdom with dependency to node 16. 23.0.0 switches to node 18 as a minimum.
I tested the tool, no changes in behavior, and I also did not notice any changes in the logs.
How to test
Since this updates dependencies, build and open the tool. Observe the logs to make sure we don't get any new entries.
Check also tests, that should be green again.
Follow-ups
Review checklist
Reminder for reviewers