Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the rendering of the tab bar tooltip if no caption is provided #13945

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Prevent the rendering of the tab bar tooltip if no caption is provided #13945

merged 1 commit into from
Jul 23, 2024

Conversation

haydar-metin
Copy link
Contributor

@haydar-metin haydar-metin commented Jul 23, 2024 •
edited
Loading

What it does

  • Adds the caption label for the settings widget
  • Prevent the rendering of the tooltip by the tab bar if no caption is available

Closes #13005.

How to test

Dock the settings widget and hover the icon.

Before:
image

Fix:
image

Follow-ups

Review checklist

Reminder for reviewers

msujew
msujew approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit 7cbfc7a into eclipse-theia:master Jul 23, 2024
11 of 14 checks passed
@msujew msujew added preferences issues related to preferences ui/ux issues related to user interface / user experience labels Jul 23, 2024
@haydar-metin haydar-metin deleted the issues/13005_settings_tooltip branch July 23, 2024 15:47
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
preferences issues related to preferences ui/ux issues related to user interface / user experience
Projects
PR Backlog
Archived in project
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Docking settings widget to the left sidebar produces empty hover element
3 participants
@haydar-metin @msujew @sgraband