BUGFIX: fixing NaN issue on IE, Safari and Firefox #7 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @IngridRegina! 🤗 I really appreciate this because I really need some help especially in this Safari thing issue. I'm currently working on some upgrade like adding themes, methods and events, and I rewritten the code to make it more optimized. So the structure of the code changed a bit, that's why I can't merge this pull request.. But I will look into it once I'm done. 😄 Regarding this NaN issue, I am now testing it to many browsers except Safari because I am using windows only. Btw, thank you for this! Looking forward to work with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the NaN problem on Safari, Internet Explorer, Firefox and Edge (it should resolve issues #7 and #3). It is worth noting though that these browsers do not support all the date formats that Chrome supports(you can see that some of the events from myEvents array are not showing). For example they don't seem to like month names, so instead of February/15/2020, 02/15/2020 should be used. So it should be made clear that the formats that are not supported shouldn't be used.