Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update or replace django-braces #23

Closed
Jawayria opened this issue Jul 27, 2021 · 7 comments
Closed

Update or replace django-braces #23

Jawayria opened this issue Jul 27, 2021 · 7 comments
Assignees
@magajh
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative
Projects
Django 3.2 Upgrade
Milestone
Django 3.2 deprec...

Comments

@Jawayria
Copy link

We use the package django-braces in edx/edx-analytics-dashboard. This package was last released in 2019 and it hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.
@Jawayria Jawayria added the outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative label Jul 27, 2021
@Jawayria Jawayria added this to TODO in Django 3.2 Upgrade via automation Jul 27, 2021
@magajh
Copy link

magajh commented Aug 27, 2021

Hi @natabene, I can help with this issue.

@jmbowman
Copy link

I think she's still out for another day or two, but I can go ahead and assign it to you. Thanks for looking into this!

@jmbowman jmbowman moved this from TODO to In Progress in Django 3.2 Upgrade Aug 30, 2021
@natabene natabene mentioned this issue Sep 15, 2021
Closed
@natabene
Copy link

@magajh Just checking if you had a chance to look into this.

@magajh magajh mentioned this issue Sep 17, 2021
Closed
@magajh
Copy link

magajh commented Sep 17, 2021 •
edited
Loading

Hi @natabene!
A PR that adds support for Django 3.2 was opened a while ago, all the tests seem to be passing just fine. I opened a new issue asking the supporters for a review on it. I'll keep you updated

@natabene
Copy link

@magajh Thanks so much for an update and for your help!

@natabene
Copy link

natabene commented Nov 9, 2021

Do we have a release by any chance?

@UsamaSadiq UsamaSadiq moved this from In Progress to Done in Django 3.2 Upgrade Jan 17, 2022
@UsamaSadiq
Copy link
Member

Django-braces 1.15.0 was released with Django 3.2 support which is now being used in openedx/edx-analytics-dashboard.
Marking this as Done and closing the issue now.
@magajh thanks for your help on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magajh magajh

Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative
Projects
Django 3.2 Upgrade
Done
Milestone
Django 3.2 deprecation warnings fixed
Development

No branches or pull requests
5 participants
@jmbowman @natabene @magajh @Jawayria @UsamaSadiq