Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for python 2.7, add support for Python 3.9 & Django 3.1, 3.2 #265

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

galuszkak
Copy link
Contributor

Hi @chrisjones-brack3t @kennethlove ,

This is mostly maintenance PR. I've tried to make sure everything is passing tests. Would be really grateful for review.

Thanks

@ghost
Copy link

ghost commented Oct 22, 2020

Thanks!
It helped me to get rid of such an exception

File "C:\Users\user\AppData\Local\Programs\Python\Python38-32\lib\site-packages\advanced_filters\views.py", line 11, in <module>
    from braces.views import (CsrfExemptMixin, StaffuserRequiredMixin,
  File "C:\Users\user\AppData\Local\Programs\Python\Python38-32\lib\site-packages\braces\views\__init__.py", line 3, in <module>
    from ._access import (
  File "C:\Users\user\AppData\Local\Programs\Python\Python38-32\lib\site-packages\braces\views\_access.py", line 13, in <module>
    from django.utils import six
ImportError: cannot import name 'six' from 'django.utils' 

Note to other users!

@galuszkak
Copy link
Contributor Author

Hi @kennethlove @chrisjones-brack3t ,

Kind reminder.

@galuszkak galuszkak changed the title feat: remove support for python 2.7 and add support for Django 3.1 feat: remove support for python 2.7, add support for Python 3.9 & Django 3.1, 3.2 Jul 31, 2021
@galuszkak
Copy link
Contributor Author

galuszkak commented Jul 31, 2021

Hi @kennethlove @chrisjones-brack3t ,

I've updated again this PR now with Python 3.9 and Django 3.2 and asking very kindly for review & merge.

Please also enable back new TravisCI (they migrated from Travis-CI.org to travis-ci.com and you have to re-enable it in new domain.).

If you need any help let me know.

@galuszkak
Copy link
Contributor Author

Hi @kennethlove @chrisjones-brack3t ,

Kind reminder, thanks for all hard work on this project.

@kennethlove
Copy link
Member

Sorry @galuszkak, we've both been tied up with family and work and this project is stable, so we don't check it often. I'll do my best to get your PR and others read and approved this week.

@galuszkak
Copy link
Contributor Author

Hi @kennethlove, thanks for taking time on this. I know how much time open-source takes from private life so even more gratitude from me for looking into this.

@chrisjones-brack3t
Copy link
Member

Starting to look at this today. 👍🏻

@chrisjones-brack3t chrisjones-brack3t merged commit 37a0a63 into brack3t:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants