Update the recorded index version when an index is opened #110336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mappings are updated
thecoop
added
:Distributed/Allocation
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
thecoop
commented
Jul 1, 2024
| @@ -1132,6 +1132,7 @@ private ClusterState openIndices(final Index[] indices, final ClusterState curre | |||
| .state(IndexMetadata.State.OPEN) | |||
| .settingsVersion(indexMetadata.getSettingsVersion() + 1) | |||
| .settings(updatedSettings) | |||
| .indexVersionWatermark(IndexVersion.current()) | |||
There was a problem hiding this comment.
This is the substantive change here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #102708
Update the recorded highest index version when an index is opened, not just when mappings are updated. This is to ensure that once an index has been opened by a node with a particular index version, it is then only allocated (by the in-progress index version allocator) to nodes with that index version or above