Add LZ4 compressor with Java9 perf improvements #77584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java9 added a number of features that are useful to improve compression and decompression. These include the Arrays#mismatch method and VarHandles. This commit adds compression tools forked from the java-lz4 library which include these improvements. We hope to contribute these changes back to the original project, however the project currently supports Java7 so this is not possible at the moment.
Tim-Brooks
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Only LZ4SafeUtils and SafeUtils vary from the 8.0 version. |
|
I will add microbenchmarks soon. |
These are benchmarks for the original lz4-java safe version, the varhandles "forked" version on 8.0, the method handle version, and the method handle version with forced fallback to pre-JDK9 behavior. |
|
Closing. We backported using a MR jar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java9 added a number of features that are useful to improve compression
and decompression. These include the Arrays#mismatch method and
VarHandles. This commit adds compression tools forked from the java-lz4
library which include these improvements.
This commit is a back port modification of #77153. As we target Java8 on
7.x, the Java9 methods are not available. This commit uses MethodHandles
to implement the Java9 perf methods if the JDK is JDK9+. Otherwise, it falls
back to legacy versions.