Improve Oscillator performance by avoiding fmodf #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
fastmod1f
method to the dsp utils header which is significantly faster thanfmodf(x, 1.0f)
, and use this inOscillator
for nontrivial performance gains.Details
This optimization really adds up when processing multiple oscillators in more complex applications and when using block-based DSP instead of sample-by-sample, but even with DaisySP defaults the savings are obvious.
I neglected to add this optimization to
BlOsc
because:fmodf
invocation has a variable second argument (not just 1.0f)Performance Metrics
Measured using
CpuLoadMeter
and the basic seed oscillator example fromDaisyExamples
at Sample Rate 48kHz and Block Size 4, with the POLYBLEP_TRI waveform.Before:
After: