Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGPL Library Split #196

Merged
merged 14 commits into from
Jan 8, 2024
Merged

LGPL Library Split #196

merged 14 commits into from
Jan 8, 2024

Conversation

beserge
Copy link
Contributor

@beserge beserge commented Dec 15, 2023

What this does

  • Moves all LGPL licensed modules DaisySP to a new submodule repository DaisySP-LGPL.
  • After updating libDaisy, and DaisySP (including pulling the new submodule), users can add USE_DAISYSP_LGPL=1 to their Makefile, and continue without any other changes.
  • DaisySP will stay under the MIT license, DaisySP-LGPL will be under the LGPL license.
  • Creates a new module called OnePole ported from pichenettes' stmlib/dsp/filter.h.
    • Necessary to replace the Tone filter in KarplusString without using LGPL code in the MIT codebase. Plus it's a nice module to have around.

TODO

  • The existing gh-pages docs will be temporarily split into two. The LGPL modules will have their own gh-pages for the time being.
    • I'm planning on spinning up a mkdocs site like what we have for libDaisy. At that point the LGPL docs will return.

The Modules

  • Control/line
  • Dynamics/balance
  • Dynamics/Compressor
  • Effects/bitcrush
  • Effects/fold
  • Filters/Allpass
  • Filters/Atone
  • Filters/Biquad
  • Filters/Comb
  • Filters/Mode
  • Filters/moogladder
  • Filters/NlFilt
  • Filters/Tone
  • PhysicalModelingpluck
  • PhysicalModelingpolypluck
  • Synthesis/blosc
  • Utility/jitter
  • Utility/port

Control: line
Dynamics: balance
Effects: bitcrush, fold, reverbsc
Filters: allpass, atone, biquad, comb, mode, moogladder, nlfilt, tone
PhysicalModeling: pluck, PolyPluck
Utility: jitter, port
Ported OnePole class from stmlib/dsp/filter.h
Since tone was moved to LGPL, replaced it with new OnePole LP filter from stmlib
@beserge beserge changed the title Remove LGPL modules from DaisySP LGPL Library Split Dec 15, 2023
@beserge beserge merged commit a0494a3 into master Jan 8, 2024
2 checks passed
@beserge beserge deleted the LGPL branch January 8, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant