fix: obtaining a certificate from the store when sha1 is not specifie…

…d in the configuration (#4666)
electron-userland · Mar 3, 2020 · 07693b3 · 07693b3
1 parent 8b1cebc
commit 07693b3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts b/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts
@@ -117,7 +117,7 @@ export async function getCertificateFromStoreInfo(options: WindowsConfiguration,
   const certList = rawResult.length === 0 ? [] : asArray<CertInfo>(JSON.parse(rawResult))
   for (const certInfo of certList) {
     if ((certificateSubjectName != null && !certInfo.Subject.includes(certificateSubjectName))
-        || certInfo.Thumbprint.toUpperCase() !== certificateSha1) {
+        || certificateSha1 != null && certInfo.Thumbprint.toUpperCase() !== certificateSha1) {
       continue
     }