Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appx): add support for custom extensions in appmanifest.xml #4707

Closed

Conversation

brownbl1
Copy link

Add option for specifying a path relative to the app root that gives the user the ability to specify custom xml that should be merged into the node in the appmanifest.xml. This gives the user the ability to add custom extensions that don't make sense as individual options, without breaking existing support for the options that fall under the node.

Add option for specifying a path relative to the app root that gives the user the ability to specify custom xml that should be merged into the <Extensions/> node in the appmanifest.xml. This gives the user the ability to add custom extensions that don't make sense as individual features, without breaking existing support for the options that fall under the <Extensions/> node.
@brownbl1
Copy link
Author

I regenerated the scheme.json using yarn schema so that is why some of the nodes in that document are re-arranged a bit. Otherwise, there are a few small whitespace changes that are unrelated but that seem to be in the right direction, so I left them in. :)

@brownbl1
Copy link
Author

Also, when running the yarn schema command, it failed at first, until I added the following to package.json:
image

Figured that should be a separate PR, which I'm happy to do if you think it's worth it.

@brownbl1
Copy link
Author

brownbl1 commented Mar 1, 2020

I am not sure why the tests are sometimes failing.. looks like they pass in 3 out of the 4 runs.

develar added a commit to develar/electron-builder that referenced this pull request Mar 3, 2020
@develar develar closed this in 6d7b25c Mar 3, 2020
@brownbl1
Copy link
Author

brownbl1 commented Mar 3, 2020

Thanks for taking this into master.. looking forward to the next release so we can start using it!

@develar
Copy link
Member

develar commented Mar 3, 2020

@brownbl1 Thanks for feature, pre-release version is available for use — https://github.com/electron-userland/electron-builder/releases/tag/v22.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants