Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move disableSanityCheckAsar to within checkFileInPackage for non-asar verification #8124

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Mar 11, 2024

fix: move disableSanityCheckPackage to within checkFileInPackage to not bypass non-asar usage

Renamed to disableSanityCheckAsar for more explicit definition

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 6722d1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 6722d1c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65ef33c1c6751a00085db303
😎 Deploy Preview https://deploy-preview-8124--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta changed the title fix: move disableSanityCheckPackage to within checkFileInPackage for non-asar verification fix: move disableSanityCheckAsar to within checkFileInPackage for non-asar verification Mar 11, 2024
@mmaietta mmaietta merged commit e029258 into master Mar 11, 2024
17 checks passed
@mmaietta mmaietta deleted the disableSanityCheck branch March 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant