Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not chmod for 7za when process.env.USE_SYSTEM_7ZA is true #8152

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

beyondkmp
Copy link
Collaborator

fix #8151

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 4ed3ac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
builder-util Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-publish Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 4ed3ac6
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6601a46cc0f2f7000806d85f
😎 Deploy Preview https://deploy-preview-8152--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 25, 2024

Many thanks @beyondkmp ! Great catch

@mmaietta mmaietta merged commit a999da4 into electron-userland:master Mar 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting USE_SYSTEM_7ZA environment variable breaks the build
3 participants